This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Disable frozen dicts by default #3987
Merged
+18
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
previously requested changes
Oct 1, 2018
hawkowl
force-pushed
the
hawkowl/frozendicts
branch
from
3a1789d to
5441a99
Compare
richvdh
previously requested changes
Oct 2, 2018
richvdh
reviewed
Oct 2, 2018
| # NOTE: This is overridden by the configuration by the Synapse worker apps, but | ||
| # for the sake of tests, it is set here while it cannot be configured on the | ||
| # homeserver object itself. | ||
| USE_FROZEN_DICTS = strtobool(os.environ.get("SYNAPSE_USE_FROZEN_DICTS", "0")) |
There was a problem hiding this comment.
is there an intention to set this for the tests somewhere?
richvdh
reviewed
Oct 2, 2018
| @@ -136,6 +136,8 @@ def default_config(name): | |||
| config.rc_messages_per_second = 10000 | |||
| config.rc_message_burst_count = 10000 | |||
|
|
|||
| config.use_frozen_dicts = False | |||
There was a problem hiding this comment.
I'm wondering if this is actually used (since afaict use_frozen_dicts is only read by code which is never run under the UTs), and if not I would probably choose to omit this. But I'm not that bothered and this needs merging.
richvdh
approved these changes
Oct 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.